Make SafeEvpPKeyHandle.OpenKeyFromProvider throw PNSE on OSSL less than 3.0 #106397
+99
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
reviewed
Aug 14, 2024
...s/System.Security.Cryptography/src/System/Security/Cryptography/SafeEvpPKeyHandle.OpenSsl.cs
Outdated
Show resolved
Hide resolved
vcsjones
reviewed
Aug 14, 2024
src/libraries/System.Security.Cryptography/tests/OpenSslNamedKeysTests.manual.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Aug 19, 2024
src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey.h
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Aug 19, 2024
src/libraries/System.Security.Cryptography/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Aug 20, 2024
|
/backport to release/9.0-rc1 |
|
Started backporting to release/9.0-rc1: https://github.com/dotnet/runtime/actions/runs/10486290096 |
4 tasks
|
/backport to release/9.0-rc2 |
|
Started backporting to release/9.0-rc2: https://github.com/dotnet/runtime/actions/runs/10487089426 |
|
@krwq an error occurred while backporting to release/9.0-rc2, please check the run log for details! Error: The specified backport target branch release/9.0-rc2 wasn't found in the repo. |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10487129178 |
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #105175
Description:
defaultprovider - they're not as comprehensive as existing manual tests because losing info about provider from SafeEvpPKeyHandle will not cause them to fail (this is becauseNULLis equivalent todefaultprovider so they may accidentally pass) - they will exercise the new logic in the DuplicateHandle and other places in the automated tests